Promotion 2024-08-27 prod (#6519) #6525

dsotirho-ucsc · 2024-08-28T20:23:07Z

Connected issue: #6519

Notes

Full reindex required for Fix: Verbatim JSONL manifest issues (#6453) #6459

Checklist

Author

Target branch is prod
Name of PR branch matches promotions/yyyy-mm-dd-prod
On ZenHub, PR is connected to the promotion issue it resolves
PR description links to connected issue
Title of connected issue matches Promotion yyyy-mm-dd
PR title starts with title of connected issue followed by prod
PR title references the connected issue

Author (reindex, API changes)

This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for prod _{or requires a full reindex or is not labeledreindex:prod}

Author (upgrading deployments)

This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

System administrator (after approval)

Actually approved the PR
Labeled PR as no sandbox
Moved ticket to Approved column
PR is assigned to only the operator

Operator (before pushing merge the commit)

Pushed PR branch to GitHub
Ran _select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply _{or this PR is not labeled deploy:shared}
Made a backup of the GitLab data volume in prod (see operator manual for details) _{or this PR is not labeled backup:gitlab}
Ran _select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Checked the items in the next section _{or this PR is labeled deploy:gitlab}
PR is assigned to only the system administrator _{or this PR is not labeled deploy:gitlab}

System administrator

Background migrations for prod.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator

Operator (before pushing merge the commit)

Ran _select prod.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
The title of the merge commit starts with the title of this PR
Added PR # reference to merge commit title
Collected commit title tags in merge commit title _{but excluded any p tags}
Pushed merge commit to GitHub

Operator (after pushing the merge commit)

Pushed merge commit to GitLab prod
Build passes on GitLab prod
Reviewed build logs for anomalies on GitLab prod
Deleted PR branch from GitHub
Moved connected issue to Merged stable column on ZenHub
Moved promoted issues from Merged lower to Merged stable column on ZenHub
Moved promoted issues from Lower to Stable column on ZenHub

Operator (reindex)

Deindexed all unreferenced catalogs in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
Deindexed specific sources in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
Indexed specific sources in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
Started reindex in prod _{or this PR does not require reindexing prod}
Checked for, triaged and possibly requeued messages in both fail queues in prod _{or this PR does not require reindexing prod}
Emptied fail queues in prod _{or this PR does not require reindexing prod}

Operator

PR is assigned to only the system administrator

System administrator

Removed unused image tags from pycharm image on DockerHub _{or this promotion does not alter references to that image}
Removed unused image tags from elasticsearch image on DockerHub _{or this promotion does not alter references to that image}
Removed unused image tags from bigquery_emulator image on DockerHub _{or this promotion does not alter references to that image}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

Originally committed as 00866ee with wrong title: [p] Fix: FedRAMP inventories review issues are created without labels (#6461)

…6500) Originally committed as b54591d with wrong title: [p] Fix: FedRAMP inventories review issues are created without labels (#6461, PR #6500)

…2024-32002) (#6352, PR #6405)

)

codecov · 2024-08-28T20:44:55Z

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.39%. Comparing base (f4f4375) to head (347b2fb).
Report is 19 commits behind head on prod.

Files with missing lines	Patch %	Lines
src/azul/terraform.py	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             prod    #6525      +/-   ##
==========================================
- Coverage   85.42%   85.39%   -0.03%     
==========================================
  Files         156      156              
  Lines       20674    20682       +8     
==========================================
+ Hits        17660    17662       +2     
- Misses       3014     3020       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coveralls · 2024-08-28T20:45:50Z

coverage: 85.415% (-0.02%) from 85.438%
when pulling 347b2fb on promotions/2024-08-27-prod
into 27c4aef on prod.

hannes-ucsc

#6526 (review)

hannes-ucsc

Please deploy late Friday so that the reindex occurs over the weekend.

Note that I removed some potentially confusing verbiage from the description.

nadove-ucsc and others added 16 commits August 14, 2024 14:04

Rename contents to value in JSONL manifest (#6453)

db4a9b6

[r] Use DCP2 schema name for HCA replica_type (#6453)

7766c1d

[r] Fix: Verbatim JSONL manifest issues (#6453, PR #6459)

e1bb690

Fix: Service responses are not compressed (#6360)

606e717

Fix: Service responses are not compressed (#6360, PR #6412)

d4f970b

Fix: Alarm api_unauthorized for HeadBucket from AWS Config (#6134)

2ed4a01

Originally committed as 00866ee with wrong title: [p] Fix: FedRAMP inventories review issues are created without labels (#6461)

Fix: Alarm api_unauthorized for HeadBucket from AWS Config (#6134, PR #…

bcdc152

…6500) Originally committed as b54591d with wrong title: [p] Fix: FedRAMP inventories review issues are created without labels (#6461, PR #6500)

Replace Python image with the slim version (#6352)

8dd1007

[R] Ran make requirements_update

966aa94

[R] Ran make requirements_update again

f712668

[R] Fix: Execution of untrusted code when cloning Git submodule (CVE-…

29e84a1

…2024-32002) (#6352, PR #6405)

Fix incorrect expected test value

3b6c69a

Fix: Inconsistent null count in tissue atlas term facet (#6458)

d8918d6

[r] Index dcp41 in prod (#6501)

caec841

Fix: Inconsistent null count in tissue atlas term facet (#6458, PR #6482

ca70fc1

)

[r] Index dcp41 in prod (#6501, PR #6504)

d769f27

dsotirho-ucsc requested a review from hannes-ucsc as a code owner August 28, 2024 20:23

github-actions bot added the orange [process] Done by the Azul team label Aug 28, 2024

dsotirho-ucsc added deploy:shared [process] PR requires deploying `shared` component reindex:prod [process] PR requires reindexing prod labels Aug 28, 2024

dsotirho-ucsc assigned hannes-ucsc Aug 28, 2024

hannes-ucsc requested changes Aug 28, 2024

View reviewed changes

hannes-ucsc added the 1 review [process] Lead requested changes once label Aug 28, 2024

hannes-ucsc removed their assignment Aug 28, 2024

[H r] Remove project 248c5dc3 from dcp41 (#6521)

347b2fb

dsotirho-ucsc assigned hannes-ucsc Aug 29, 2024

hannes-ucsc approved these changes Aug 29, 2024

View reviewed changes

hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Aug 29, 2024

hannes-ucsc assigned dsotirho-ucsc and unassigned hannes-ucsc Aug 29, 2024

dsotirho-ucsc merged commit 32ba09e into prod Aug 30, 2024
9 checks passed

dsotirho-ucsc deleted the promotions/2024-08-27-prod branch September 3, 2024 15:30

dsotirho-ucsc assigned hannes-ucsc and unassigned dsotirho-ucsc Sep 3, 2024

hannes-ucsc removed their assignment Sep 4, 2024

achave11-ucsc added a commit that referenced this pull request Sep 4, 2024

[H] Backport: 347b2fb (#6521, PR #6525, PR #6540)

eeefafc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promotion 2024-08-27 prod (#6519) #6525

Promotion 2024-08-27 prod (#6519) #6525

dsotirho-ucsc commented Aug 28, 2024 •

edited by hannes-ucsc

Loading

codecov bot commented Aug 28, 2024 •

edited

Loading

coveralls commented Aug 28, 2024 •

edited

Loading

hannes-ucsc left a comment

hannes-ucsc left a comment •

edited

Loading

Promotion 2024-08-27 prod (#6519) #6525

Promotion 2024-08-27 prod (#6519) #6525

Conversation

dsotirho-ucsc commented Aug 28, 2024 • edited by hannes-ucsc Loading

Notes

Checklist

Author

Author (reindex, API changes)

Author (upgrading deployments)

System administrator (after approval)

Operator (before pushing merge the commit)

System administrator

Operator (before pushing merge the commit)

Operator (after pushing the merge commit)

Operator (reindex)

Operator

System administrator

Shorthand for review comments

codecov bot commented Aug 28, 2024 • edited Loading

Codecov Report

coveralls commented Aug 28, 2024 • edited Loading

hannes-ucsc left a comment

Choose a reason for hiding this comment

hannes-ucsc left a comment • edited Loading

Choose a reason for hiding this comment

dsotirho-ucsc commented Aug 28, 2024 •

edited by hannes-ucsc

Loading

codecov bot commented Aug 28, 2024 •

edited

Loading

coveralls commented Aug 28, 2024 •

edited

Loading

hannes-ucsc left a comment •

edited

Loading